Looks good to me as well.
Thanks,
Dinesh
On 6/3/2016 10:45 AM, Tim Bell wrote:
Erik:
In my recent implementation of bundle targets, I also made configure
prefer gnu tar to Solaris tar on Solaris. Unfortunately, bundles
created by gnu tar are not always compatible with Solaris tar.
Typically, this error message is given when Solaris tar (at least
older versions of it) tries to untar bundles created by the new target:
tar: ././@LongLink: typeflag 'L' not recognized, converting to
regular file
To fix this, gnu tar can be run in various compatibility modes. I
have found the "ustar" mode to work well in this case. (Incidentally,
USTAR is also the file type that the Solaris file command reports for
tar files). This patch adds an optional extra parameter to tar create
commands and sets it to --format=ustar when using gnu tar on Solaris.
Bug: https://bugs.openjdk.java.net/browse/JDK-8157479
Webrev: http://cr.openjdk.java.net/~erikj/8157479/webrev.top.01/
Looks good.
/Tim
