----- Original Message ----- > Hello, > > In general it looks good. It's nice to see that this also fixes that > warning output from configure. My only nit is the comment describing the > parameters for FLAGS_SETUP_GCC6_COMPILER_FLAGS. It indicates that it > takes named parameters while it actually just takes positional. Please > either change it to named parameters or fix the comment. >
Ah, that's because it was named parameters for a while, then I changed it because it was easier than trying to get ARG_PREFIX instead of $1 into [$]$1CFLAGS_JDK and friends. Fixed in: http://cr.openjdk.java.net/~andrew/8156980/webrev.02/ I'll let someone on your side push it through so you can regenerate your internal configure script at the same time. > Thanks for fixing this! > Thanks :) > /Erik > > On 2016-07-05 07:27, Andrew Hughes wrote: > > Webrev: http://cr.openjdk.java.net/~andrew/8156980/webrev.01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8156980 > > > > With "8151841: Build needs additional flags to compile with GCC 6", > > we added a number of compiler flags which were needed to build > > OpenJDK with GCC 6. Checks for these flags were added to configure, > > and the flags passed to the JDK and HotSpot builds by CFLAGS/CXXFLAGS_JDK > > and hotspot-spec.gmk.in respectively. > > > > Following "8152666: The new Hotspot Build System" and > > "8150601: Remove the old Hotspot build system", the hotspot-spec.gmk.in > > file was removed, so the flags were no longer passed to the HotSpot > > build. HotSpot now uses JVM_CFLAGS via the same configure process > > as the JDK obtains CFLAGS_JDK and CXXFLAGS_JDK[*]. > > > > This webrev fixes the regression introduced by 8152666 by adding > > the flags to JVM_CFLAGS. It also adapts FLAGS_SETUP_GCC6_COMPILER_FLAGS > > to take a prefix, as other macros in flags.m4 do, and calls > > TOOLCHAIN_PREPARE_FOR_VERSION_COMPARISONS before the version check. > > The lack of the latter lead to configure executing: > > > > if test $OPENJDK_BUILD_COMPARABLE_ACTUAL_VERSION -ge > > $COMPARABLE_REFERENCE_VERSION > > > > with OPENJDK_BUILD_COMPARABLE_ACTUAL_VERSION ever being set, causing > > test to print an error. > > > > With this fix, the flags again make it into the build. > > > > [*] It should really be CXXFLAGS_JVM as they are flags for the C++ > > compiler. > > -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
