On 30/09/2016 10:43, Chris Hegarty wrote:


Ooh, this is quite clever, levering the already computed packages
list from the running VM to add the packages attribute to the module
info.  One minor concern ( which I think should be ok ) is the
updating of the module-info.class files of the running VM. ( I
think this is ok, as these files should be read once at start up.
It's okay because there is nothing else accessing them when this tool is running.



Additionally, do you want to run with --add-modules java.se.ee to
include the 6 "EE" modules?
Not needed as the tool adds the class file attribute to every module-info.class in jdk/modules/*.

-Alan

Reply via email to