Erik:
Looks good to me as well.
Tim
Hello,
Thanks!
Yes, the redefinition is a (minor) reason for concern. I just had a
discussion with Magnus about it. In some cases I would have moved the
definition to spec.gmk.in, which really is the only place to put common
definitions. In this case I chose not to because the file is located in
a rather well defined place (top of the exploded image which is where it
would logically go) so it's far from arbitrary. I guess this sticks out
because the same variable name is used in both makefiles.
/Erik
On 2016-11-30 13:26, David Holmes wrote:
Hi Erik,
Seems reasonable. Only query I have is defining BASE_RELEASE_FILE in
two places ?
Thanks,
David
On 30/11/2016 9:17 PM, Erik Joelsson wrote:
The release file is part of all product images in the build. We used to
generate it for each image individually, but a while back, we changed to
generate it just for the exploded image, and then let jlink use the one
as source for generating individually modified release files for each
linked image.
The problem is that the release file is still generated in Images.gmk,
which is called multiple times. This means each call to this file may
try to generate the release file at the same time, which may result in a
corrupt release file.
This patch moves the creation of the base release file to a separate
build step.
Bug: https://bugs.openjdk.java.net/browse/JDK-8170528
Webrev: http://cr.openjdk.java.net/~erikj/8170528/webrev.01
/Erik
