Hi Mandy,

On 02/02/17 02:41, Mandy Chung wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.06

Does java.management still depend on java.base/jdk.internal.module?

Well spotted! It doesn't. I have updated module-info.java for java.base.

http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.07

http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.06/java.management.rmi-summary.html


Maybe the first sentence of @provides could be simplified to:

A provider of JMXConnectorProvider for the RMI protocol.
A provider of JMXConnectorServerProvider for the RMI protocol.

Done. But I think you meant A provider of JMXConnector[Server] for the RMI protocol.

http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.07/java.management.rmi-summary.html

best regards,

-- daniel


Otherwise looks good.
Mandy




Reply via email to