If you have signed the OCA, you can post your proposed change here and I
or someone else will sponsor it once we agree that it looks good.
/Erik
On 2017-08-30 14:27, Jason Yong wrote:
Thanks Eric,
Is the next step is to get a sponsor for the change or should I post
my proposed change first?
Jason
Regards,
*Jason Yong*
CEng MEng MIET
Software Engineer, IBM Runtimes Technology
IBM Hybrid Cloud
------------------------------------------------------------------------
*Phone:*44-1962-815256*
E-mail:*_yon...@uk.ibm.com_ <mailto:yon...@uk.ibm.com>*
Find me on:*LinkedIn: http://uk.linkedin.com/pub/jason-yong/90/998/b22
<http://uk.linkedin.com/pub/jason-yong/90/998/b22>*and within IBM
on:*IBM Connections:
https://w3-connections.ibm.com/profiles/html/profileView.do?key=acdaa606-99cf-4e69-bdd5-2ea7f0396035
<https://w3-connections.ibm.com/profiles/html/profileView.do?key=acdaa606-99cf-4e69-bdd5-2ea7f0396035>
IBM
Hursley Park
Hursley, SO212JN
United Kingdom
From: Erik Joelsson <erik.joels...@oracle.com>
To: Jason Yong <jason_y...@uk.ibm.com>, build-dev@openjdk.java.net
Date: 29/08/2017 12:55
Subject: Re: CompileJavaModule.gmk overrides values from a custom
extension gmk
------------------------------------------------------------------------
Hello Jason,
Your suggestion makes sense. The only reason these variables have :=
today is that we (at Oracle) haven't had a need for appending to those
particular variables (yet).
/Erik
On 2017-08-29 11:31, Jason Yong wrote:
> Hello,
>
> I've had an issue where I've had a custom extension to
CompileJavaModules.gmk with the variable java.base_COPY set to files
that I wanted to be copied across but its value was overwritten by
CompileJavaModules.gmk.
>
> I would like to propose changes that would allow a custom extensions
to update variables listed in CompileJavaModules.gmk. This issue is
similar to bug JDK-8064372
(https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8064372&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=_pd0JudnAMtzyOP3NkOCP7ozDRbZ9ukki8lLmogKLJI&m=qG_YEjgXnzBfNvN5ztSbjIVP3nZ5SaZCibl7SHJjTfc&s=2mMmeC6jKTJu1OgK0Lssib1LKQvOFX3BwzIcJAebSeU&e=)
but affects all the other variables such as:
>
> java.activation_SETUP
> java.base_ADD_JAVAC_FLAGS
> java.base_COPY
> java.base_CLEAN
> etc
>
> The fix is also similar, changing := to += allowing the custom
extension to append to the variable if already set and create it if
its not.
> I would appreciate any feedback and help on what the next steps
would be.
>
> Thanks
>
> Jason
>
>
> Jason Yong
> CEng MEng MIET
> Software Engineer, IBM Runtime Technologies
> IBM Hybrid Cloud
> Phone: 44-1962-815256
> E-mail: yon...@uk.ibm.com
> Find me on: and within IBM on:
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with
number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU
>
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with
number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
