On 2017-09-04 11:47, Lindenmaier, Goetz wrote:
Hi Magnus,

thanks for looking at my change.

Thanks for forwarding to the proper list. I'm often not sure what's the right 
one,
and sometimes it's ambiguous anyways. Like this one, which concerns stack 
overflow
handling. The same problem exists with all the categories of the Jira bugs.

The rule of thumb is: Does the patch touch files in the make or autoconf directories? If so, cc build-dev. (For really trivial changes you can skip this, but then you must be *certain* that the change is trivial -- not always easy to say when dealing with makefiles)

The good thing with mailing lists, as opposted to categories in Jira, is that you can cc multiple lists.

/Magnus


Best regards,
  Goetz.

-----Original Message-----
From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
Sent: Montag, 4. September 2017 10:42
To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; hotspot-runtime-
d...@openjdk.java.net; build-dev <build-dev@openjdk.java.net>
Subject: Re: RFR(M): 8187045: [linux] Not all libraries in the VM are linked
with -z,noexecstack

Hi Goetz,

Since this is mostly a build change, it need to be reviewed on build-dev.

However, it looks good to me from a build perspective. I have not
reviewed the hotspot test files.

/Magnus

On 2017-09-01 15:05, Lindenmaier, Goetz wrote:
Hi,

I found that not all libraries are linked with -z,noexecstack.
This lead to errors with our linuxppc64 build.  The linker omitted
the flag altogether, which is interpreted as a lib with execstack.

This change contains a small test that scans all libraries in the tested VM
to have the noexecstack flag set. It utilizes the elf parser in the VM for this.
Further -z,noexecstack is now passed to all libraries.

Please review this change. I please need a sponsor.
http://cr.openjdk.java.net/~goetz/wr17/8187045-
execstackLink/webrev.01/
http://cr.openjdk.java.net/~goetz/wr17/8187045-
execstackLink/webrev.01-hs/
Best regards,
    Goetz.

Reply via email to