Hi Magnus,

This seems fine to me.

Sanity check: the various -Ixxx will be processed in order and the first file found will be used - right? ie we won't unintentionally pick up the java.base jni.h.

Thanks,
David

On 18/10/2017 6:04 PM, Magnus Ihse Bursie wrote:
The file jvmticmlr.h is stored twice in the repo, both in hotspot and in java.base. They are both identical, and only the java.base version is included in the final product. This might arguably have been useful in a pre-consolidated world, but makes absolutely no sense now.

Bug: https://bugs.openjdk.java.net/browse/JDK-8189607
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8189607-remove-duplicated-jvmticmlr/webrev.01

/Magnus

Reply via email to