> On 18 Dec 2017, at 17:52, David Holmes <[email protected]> wrote: > > On 19/12/2017 11:42 AM, Paul Sandoz wrote: >> Looks good to me. >> I am including HS dev for the class file version changes: >> http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ >> http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version-build-changes/webrev/ >> We can push the above patches under the following issue rather that merge >> into Joe's patch: >> https://bugs.openjdk.java.net/browse/JDK-8191913 >> Hopefully by the next release we can merge together and with less changes >> required. > > Changes seem okay, but I'm still a little concerned about using classfile > version 55 before we actually bump the JDK version to 11. >
Thanks, jdk and hs 1 to 4 tier testing showed no issues. > And it still isn't clear to me who will be doing the actual version update > and when? > Unsure, we are still working out the steps, hopefully it would follow on fairly quickly. Plus there are quite a few follow on actions we can do to make this simpler for next time (especially for hardcoded values in build scripts and tests). Paul.
