[build-dev redirect] On Tue, Jan 9, 2018 at 2:16 AM, Ao Qi <a...@loongson.cn> wrote:
> Hi, > > I found it failed to build zero. The repository I used is > http://hg.openjdk.java.net/jdk/jdk > I get this error (on Ubuntu 16.04 x86): > > $ sh configure --with-boot-jdk=/my-path-to-jdk9 --with-jvm-variants=zero > $ make hotspot > Building target 'hotspot' in configuration > 'linux-x86_64-normal-zero-release' > Compiling 2 files for BUILD_JVMTI_TOOLS > Creating support/modules_libs/java.base/libjsig.so from 1 file(s) > Creating support/modules_libs/java.base/server/libjvm.so from 578 file(s) > Creating hotspot/variant-zero/libjvm/gtest/libjvm.so from 76 file(s) > Creating hotspot/variant-zero/libjvm/gtest/gtestLauncher from 1 file(s) > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/safepoint.cpp: In > function 'static void > SafepointSynchronize::check_for_lazy_critical_native(JavaThread*, > JavaThreadState)': > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/ > safepoint.cpp:730:25: > error: '<anonymous>' may be used uninitialized in this function > [-Werror=maybe-uninitialized] > if (stub_cb != NULL && > ^ > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/safepoint.cpp: In > static member function 'static void > SafepointSynchronize::check_for_lazy_critical_native(JavaThread*, > JavaThreadState)': > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/ > safepoint.cpp:730:25: > error: '<anonymous>' may be used uninitialized in this function > [-Werror=maybe-uninitialized] > cc1plus: all warnings being treated as errors > lib/CompileJvm.gmk:212: recipe for target > '/home/loongson/aoqi/jdk10/jdk/build/linux-x86_64-normal- > zero-release/hotspot/variant-zero/libjvm/objs/safepoint.o' > failed > make[3]: *** > [/home/loongson/aoqi/jdk10/jdk/build/linux-x86_64-normal- > zero-release/hotspot/variant-zero/libjvm/objs/safepoint.o] > Error 1 > make[3]: *** Waiting for unfinished jobs.... > make/Main.gmk:268: recipe for target 'hotspot-zero-libs' failed > make[2]: *** [hotspot-zero-libs] Error 1 > > ERROR: Build failed for target 'hotspot' in configuration > 'linux-x86_64-normal-zero-release' (exit code 2) > > === Output from failing command(s) repeated here === > * For target hotspot_variant-zero_libjvm_objs_safepoint.o: > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/safepoint.cpp: In > function 'static void > SafepointSynchronize::check_for_lazy_critical_native(JavaThread*, > JavaThreadState)': > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/ > safepoint.cpp:730:25: > error: '<anonymous>' may be used uninitialized in this function > [-Werror=maybe-uninitialized] > if (stub_cb != NULL && > ^ > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/safepoint.cpp: In > static member function 'static void > SafepointSynchronize::check_for_lazy_critical_native(JavaThread*, > JavaThreadState)': > /home/loongson/aoqi/jdk10/jdk/src/hotspot/share/runtime/ > safepoint.cpp:730:25: > error: '<anonymous>' may be used uninitialized in this function > [-Werror=maybe-uninitialized] > cc1plus: all warnings being treated as errors > > * All command lines available in > /home/loongson/aoqi/jdk10/jdk/build/linux-x86_64-normal- > zero-release/make-support/failure-logs. > === End of repeated output === > > === Make failed targets repeated here === > lib/CompileJvm.gmk:212: recipe for target > '/home/loongson/aoqi/jdk10/jdk/build/linux-x86_64-normal- > zero-release/hotspot/variant-zero/libjvm/objs/safepoint.o' > failed > make/Main.gmk:268: recipe for target 'hotspot-zero-libs' failed > === End of repeated output === > > Hint: Try searching the build log for the name of the first failed target. > Hint: See doc/building.html#troubleshooting for assistance. > > /home/loongson/aoqi/jdk10/jdk/make/Init.gmk:291: recipe for target 'main' > failed > make[1]: *** [main] Error 1 > /home/loongson/aoqi/jdk10/jdk/make/Init.gmk:186: recipe for target > 'hotspot' failed > make: *** [hotspot] Error 2 > > > I made a small patch to pass the build. Could someone help to review and > submit this patch? I had signed OCA. > > patch: > > diff -r 9a29aa153c20 src/hotspot/cpu/zero/frame_zero.inline.hpp > --- a/src/hotspot/cpu/zero/frame_zero.inline.hpp Mon Jan 08 07:13:27 2018 > -0800 > +++ b/src/hotspot/cpu/zero/frame_zero.inline.hpp Tue Jan 09 15:38:05 2018 > +0800 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights > reserved. > * Copyright 2007, 2008, 2009, 2010 Red Hat, Inc. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > @@ -43,23 +43,16 @@ > inline frame::frame(ZeroFrame* zf, intptr_t* sp) { > _zeroframe = zf; > _sp = sp; > + _cb = NULL; > + _deopt_state = not_deoptimized; > switch (zeroframe()->type()) { > case ZeroFrame::ENTRY_FRAME: > _pc = StubRoutines::call_stub_return_pc(); > - _cb = NULL; > - _deopt_state = not_deoptimized; > break; > > - case ZeroFrame::INTERPRETER_FRAME: > - _pc = NULL; > - _cb = NULL; > - _deopt_state = not_deoptimized; > - break; > - > + case ZeroFrame::INTERPRETER_FRAME: // fall through > case ZeroFrame::FAKE_STUB_FRAME: > _pc = NULL; > - _cb = NULL; > - _deopt_state = not_deoptimized; > break; > > default: > > > Thanks, > Ao Qi >