On 01/17/2018 03:07 PM, Adam Farley8 wrote:
Because the default build instructions don't work in this scenario, and
if all the effort to impliment a clone-config-make model was intended to
encourage more users to attempt a local build (in order to try their hand
at a fixing a bug themselves or something) it makes sense to me to try
to maintain a scenario where OpenJDK can build to completion across a wide
variety of toolchains.
There are other, higher hurdles which you have to overcome in order to be
able to contribute patches, i.e. signing the OCA. If OpenJDK was a project
hosted on github where drive-by patches are more common, you would have
a point.
Building OpenJDK from source isn't exactly something
that is done by normal users. If someone is willing to hack on the OpenJDK
code base, I would assume they know about -Werror and similar options and
how to control them.
I don't agree. Someone should not have to be familiar with gcc options in
order to fix a typo, or change some Java code. And besides, we have a clear
and simple four-step build process (clone, get source, configure, make).
Why would we want people to have to fail their build and experiment with
different options, when we can fix the problem right here and now.
Because "-Werror" isn't some obscure option. It's something very common
that every C/C++ developer should know about. Also, you don't need to
rebuild the whole JDK to contribute a patch to fix an obvious typo.
I mean, yes, you can change that to have -Werror turned off by default,
but having the compiler complain less is usually a bad idea.
In general, yes. In this one compile it's breaking the build.
David suggested disabling this warning. The simplest way I see to do this
is to change Awt2dLibraries.gmk.
The code is here:
$(_eval_ $(call SetupNativeCompilation,BUILD_LIBJAVAJPEG, \
LIBRARY := _javajpeg_, \
OUTPUT_DIR := $(INSTALL_LIBRARIES_HERE), \
SRC := $(LIBJAVAJPEG_SRC), \
INCLUDE_FILES := $(BUILD_LIBJAVAJPEG_INCLUDE_FILES), \
OPTIMIZATION := HIGHEST, \
Switching the OPTIMIZATION to LOW will solve this at a stroke.
First you said you want to disable -Werror by default and make all
warnings non-fatal and now you want to address one particular warning.
I'm confused. As mentioned in another discussion I linked, hunting
for individual warnings a lost battle with all the different toolchains
downstreams are going to use.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
