Looks good to me! Thanks for fixing Erik.
One pre-existing query:
! # Make sure MaxRAMPercentage is high enough to not cause OOM or
swapping since
Surely "high" should be "low" ??
Thanks,
David
On 1/02/2018 9:52 AM, Erik Joelsson wrote:
An internal test at Oracle is failing because of a faulty shell
expression in a makefile for calculating the value for MaxRAMPercentage.
We already have such a calculation in TestCommon.gmk so we should just
use that, but it needs to be exported in a separate variable to be able
to do so.
Bug: https://bugs.openjdk.java.net/browse/JDK-8196524
Webrev: http://cr.openjdk.java.net/~erikj/8196524/webrev.01/
/Erik