On Wed, Feb 7, 2018 at 3:20 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> > > On 07/02/2018 14:13, Thomas Stüfe wrote: > >> Could this also explain what we see in some of our nightlies? The builds >> broke on some platforms for us (e.g. linux ppcle). It seems that >> "@LIBZ_CFLAGS@" does not get expanded correctly and finds its way into >> the >> makefile, confusing the compiler: >> >> ( /sapmnt/appl_sw/gcc-4.8/bin/gcc ... -g1 -fPIC @LIBZ_CFLAGS@ ... -o >> /net/ >> usr.work/openjdk/nb/linuxppc64le/nightly/output-jdk- >> fastdebug/support/native/java.base/libzip/Adler32.o >> /net/ >> usr.work/openjdk/nb/linuxppc64le/nightly/jdk/src/java.base/ >> share/native/libzip/Adler32.c >> >> gcc: error: @LIBZ_CFLAGS@: No such file or directory >> >> ? >> >> Several of us have been running into an issue like this on macOS too, > it's tracked as JDK-8196951 [1]. > > Locally I'm using the following to workaround it: > > diff -r ce02b30d382b make/autoconf/lib-bundled.m4 > --- a/make/autoconf/lib-bundled.m4 Wed Feb 07 11:57:51 2018 +0000 > +++ b/make/autoconf/lib-bundled.m4 Wed Feb 07 14:18:47 2018 +0000 > @@ -212,6 +212,7 @@ > if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then > LIBZ_CFLAGS="$LIBZ_CFLAGS -I$TOPDIR/src/java.base/share/ > native/libzip/zlib" > else > + LIBZ_CFLAGS="" > LIBZ_LIBS="-lz" > fi > > -Alan. > > [1] https://bugs.openjdk.java.net/browse/JDK-8196951 > Thanks for the pointer! ..Thomas
