Hi Goetz, I updated the webrev with the suggested update http://cr.openjdk.java.net/~lancea/8190378/open_changes/tests_webrev/test/jdk/tools/launcher/HelpFlagsTest.java.sdiff.html
Best Lance > On Feb 7, 2018, at 3:20 PM, Lindenmaier, Goetz <goetz.lindenma...@sap.com> > wrote: > > Hi Lance, > > Would you mind to add similar change as for > test/jdk/tools/launcher/VersionCheck.java > also for > test/jdk/tools/launcher/HelpFlagsTest.java > > That test is pretty recent which is why you may have missed it. > It will not fail though, there will just be left over stuff in it. > > Best regards, > Goetz. > > > -----Original Message----- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf > Of Lance Andersen > Sent: Wednesday, February 7, 2018 5:57 PM > To: core-libs-dev <core-libs-...@openjdk.java.net>; build-dev > <build-dev@openjdk.java.net> > Subject: RFR 8190378: Java EE and CORBA modules removal > > Hi all, > > I think we are at a point where we are ready to start reviewing the changes > to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been > targeted to JDK 11. > The CSR for removing the modules has been approved: > https://bugs.openjdk.java.net/browse/JDK-8193757 > <https://bugs.openjdk.java.net/browse/JDK-8193757> > > The open webrev can be found at: > http://cr.openjdk.java.net/~lancea/8190378/open_changes/ > <http://cr.openjdk.java.net/~lancea/8190378/open_changes/> > > To make the open review easier, I have broken the changes into 5 webrevs: > build changes are: > http://cr.openjdk.java.net/~lancea/8190378/open_changes/build_webrev/ > <http://cr.openjdk.java.net/~lancea/8190378/open_changes/build_webrev/> > miscellaneous changes are at: > http://cr.openjdk.java.net/~lancea/8190378/open_changes/misc_webrev/ > <http://cr.openjdk.java.net/~lancea/8190378/open_changes/misc_webrev/> > module changes are at: > http://cr.openjdk.java.net/~lancea/8190378/open_changes/modules_webrev/ > <http://cr.openjdk.java.net/~lancea/8190378/open_changes/modules_webrev/> > rmic changes are at: > http://cr.openjdk.java.net/~lancea/8190378/open_changes/rmic_webrev/ > <http://cr.openjdk.java.net/~lancea/8190378/open_changes/rmic_webrev/> > test changes are at: > http://cr.openjdk.java.net/~lancea/8190378/open_changes/tests_webrev/ > <http://cr.openjdk.java.net/~lancea/8190378/open_changes/tests_webrev/> > > As part of the removal, the following issues have also been logged: > Removal of the Java EE and CORBA tools from the documentation: > https://bugs.openjdk.java.net/browse/JDK-8193906 > <https://bugs.openjdk.java.net/browse/JDK-8193906> > Updating the RMIC man pages for the removal of the -iiop and -idl options: > https://bugs.openjdk.java.net/browse/JDK-8196510 > <https://bugs.openjdk.java.net/browse/JDK-8196510> > Hotspot tests may require further updating or just removed: > https://bugs.openjdk.java.net/browse/JDK-8194310 > <https://bugs.openjdk.java.net/browse/JDK-8194310> > jdeprescan will need updates due to the removal of the Java EE and CORBA > modules: https://bugs.openjdk.java.net/browse/JDK-8194308 > <https://bugs.openjdk.java.net/browse/JDK-8194308> > > > > Best, > Lance > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
