Looks good to me. /Magnus
> 8 feb. 2018 kl. 20:59 skrev Erik Joelsson <erik.joels...@oracle.com>: > > Thanks, updated in place. > > /Erik > > >> On 2018-02-08 11:55, Tim Bell wrote: >> Erik: >> >> make/devkit/Tools.gmk >> >> line 553: one typo - 'too the' should be 'to the' >> >> Looks good otherwise. >> >> Tim >> >>> On 02/08/18 11:42, Erik Joelsson wrote: >>> Here is a new webrev with dtrace included. I have verified that it >>> builds open linux-x64 successfully with dtrace enabled both on my Ubuntu >>> without any dtrace installed as well as in mach5. >>> >>> http://cr.openjdk.java.net/~erikj/8196998/webrev.02/ >>> >>> /Erik >>> >>> >>>> On 2018-02-08 02:37, Magnus Ihse Bursie wrote: >>>> Erik, >>>> >>>> Is it possible that you could address >>>> https://bugs.openjdk.java.net/browse/JDK-8193016 at this time as well? >>>> >>>> Apart from that, it looks good to me. >>>> >>>> /Magnus >>>> >>>> 8 feb. 2018 kl. 02:49 skrev Tim Bell <tim.b...@oracle.com >>>> <mailto:tim.b...@oracle.com>>: >>>> >>>>> Erik: >>>>> >>>>>> For oracle internal builds, we need to construct a portable devkit based >>>>>> on GCC 7.3. This change contains the updated makefile logic used to >>>>>> create this. The changes adds gdb and the gold linker. It also adds >>>>>> dynamic downloading of the sysroot rpms. Several long standing bugs were >>>>>> also fixed. >>>>>> >>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8196998 >>>>>> >>>>>> Webrev: http://cr.openjdk.java.net/~erikj/8196998/webrev.01/ >>>>>> <http://cr.openjdk.java.net/%7Eerikj/8196998/webrev.01/> >>>>> >>>>> >>>>> Looks good. >>>>> >>>>> /Tim >>>>> >>> >> >