> 20 feb. 2018 kl. 22:35 skrev Erik Joelsson <erik.joels...@oracle.com>:
> 
> 
>> On 2018-02-20 12:51, Magnus Ihse Bursie wrote:
>> 
>>> On 2018-02-20 19:05, Erik Joelsson wrote:
>>> Hello,
>>> 
>>> This patch adds a build time check for uses of global operators new and 
>>> delete in hotspot C++ code. The check is only run with toolchains GCC and 
>>> Clang (Linux and Macos builds). I have also modified the Oracle devkit on 
>>> Linux to add the necessary symlink so that objdump will get picked up by 
>>> configure.
>>> 
>>> This change is depending on several fixes removing such uses that are 
>>> currently in jdk/hs so this change will need to be pushed there as well.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8198243
>>> 
>>> Webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.01/
>> It seems dtrace disappeared when you sorted the line in 
>> make/devkit/Tools.gmk. There's a new dwp, should it be there?
>> 
> Yes and yes. I added links for all the missing tools (which was dwp and 
> objdump) and removed dtrace which was accidentally added in JDK-8196998 (new 
> devkit with 7.3). Dtrace is actually handled separately a few lines above.

Then I'm ok with it. 

/Magnus

> 
> /Erik
>> Otherwise it looks good.
>> 
>> /Magnus
>> 
>>> 
>>> /Erik
>>> 
>> 
> 

Reply via email to