On 01/03/2018 18:44, Brian Burkhalter wrote:
On Feb 28, 2018, at 8:34 AM, Alan Bateman <alan.bate...@oracle.com
<mailto:alan.bate...@oracle.com>> wrote:
This look okay but I think we should looking at creating this .so in
the build, like we do for libDirectIO.so to create the shared library
needed for the direct I/O tests. All the details in
test/JtregNativeJdk.gmk.
Consider it done:
http://cr.openjdk.java.net/~bpb/8198834/webrev.00/
<http://cr.openjdk.java.net/%7Ebpb/8198834/webrev.00/>
This removes the Makefile and all .so files. The change has been
verified to work on linux-64 and solaris-sparcv9.
The rename of Launcher.c looks a bit strange, the original name looks
better to me. I see it doesn't have a copyright header so we should fix
that. For the README then you can split the jtreg line to make it easier
to read.
Otherwise looks good to me and happy to see these checked-in .so files
going away.
-Alan
