> On Mar 5, 2018, at 3:06 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04
Looks good. > > /Erik > > > On 2018-03-05 12:03, Erik Joelsson wrote: >> >> On 2018-03-05 11:46, Kim Barrett wrote: >>> Old code in toolkit.m4 did the OBJDUMP stuff unconditionally. New code >>> makes it conditional on TOOLCHAIN_TYPE. >>> That doesn’t seem right. compare.sh seems to want OBJDUMP for aix too, and >>> that’s not in the toolchain list here. >> That is a good point. I forgot about aix and was thinking more in the lines >> of not windows. Will restore the OBJDUMP code completely. >> >> /Erik
