On 03/26/2018 08:08 AM, David Holmes wrote:
> Everytime I see these zero-only platform definitions it makes we think we 
> really
> should have these isolated into a zero-specific file. At the moment this can
> paint a false picture that all these platforms have full OpenJDK ports 
> available.

Is that really the case though? If someone is reading the platform.m4 file, they
might think that but simply trying to build the server variant for ia64 would
fail very quickly anyway and people would realize it's not supported.

In the end, I think the extended portability OpenJDK highly outweighs your
reservations above. Someone who doesn't understand the difference between Zero
and the official ports, is also unlikely to try building OpenJDK from source
themselves.

> I also wonder if the values here can be reliably obtained via uname/sysconf
> or some such utility so that we don't have to list every single platform
> individually?

I think autoconf normally has support for this, yes. It's rather unusual
having to add targets manually. But you will need the mapping to VAR_CPU,
for example. I will have a look at it anyway.

For the time being, it would be nice if I can get this and a second follow-up
change for ia64 merged so downstream (currently Debian and Gentoo for ia64)
doesn't have to carry any additional patches anymore.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply via email to