On 2018-04-10 10:50, John Paul Adrian Glaubitz wrote:
Hi Erik!

On 04/10/2018 06:54 PM, Erik Joelsson wrote:
I've found the problem. In JvmFeatures.gmk we have:

ifeq ($(call check-jvm-feature, zero), true)
   JVM_CFLAGS_FEATURES += -DZERO -DCC_INTERP -DZERO_LIBARCH='"$(OPENJDK_TARGET_CPU_LEGACY_LIB)"' $(LIBFFI_CFLAGS)
   JVM_LIBS_FEATURES += $(LIBFFI_LIBS)
   ifeq ($(OPENJDK_TARGET_CPU), sparcv9)
     BUILD_LIBJVM_EXTRA_FILES := $(TOPDIR)/src/hotspot/cpu/sparc/memset_with_concurrent_readers_sparc.cpp
   endif
endif

The BUILD_LIBJVM_EXTRA_FILES is implicitly trying to set the EXTRA_FILES argument to the BUILD_LIBJVM SetupNativeCompilation call. This used to work because there was no setting of that parameter in the actual call. In a recent change, that parameter is not set to something else, overriding the assignment above.

Aha! Do you happen to know which change was responsible for that? Then I can
adjust the bug summary accordingly.

"JDK-8201236 Straighten out dtrace build logic"
To fix this, you need to add $(BUILD_LIBJVM_EXTRA_FILES) to the EXTRA_FILES line in CompileJvm.gmk.

Indeed, this fixes it! Thanks so much, I was already about to give up ;).

We should have been explicit with that parameter in the first place, then Magnus would not have missed it. Glad I could help.

/Erik
Adrian


Reply via email to