On 2018-04-13 17:23, Chris Dennis wrote:
Hi All,
It looks like the addition of support for disabling features has broken support
for enabling features that contain a ‘-‘ in their name (amusingly this includes
the 'all-gcs’ feature).
Pretty sure this is the offending code is the use of 'match($i, /-.*/)’ to
distinguish between disabled and enabled features. That regex needs to match a
‘-' only at the beginning of the line otherwise configures thinks you are
disabling the ‘ll-gcs’ feature.
You are correct. I noticed this in the follow-up bug I'm working on, to
further clean up JVM feature handling, and thought it would be enough to
fix it in that bug.
But since you ran into it, I'll make a high-priority fix. (I'm glad to
see someone is actually using this code! :-) Sorry I broke it. :()
I opened https://bugs.openjdk.java.net/browse/JDK-8201591.
/Magnus
Thanks,
Chris Dennis
