Hi Magnus, yes, that works too: http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/02/ Can I push this right away if I get a second review?
Best regards, Goetz > -----Original Message----- > From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com] > Sent: Montag, 16. April 2018 14:00 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; build-dev (build- > d...@openjdk.java.net) <build-dev@openjdk.java.net> > Subject: Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483 > > On 2018-04-16 11:16, Lindenmaier, Goetz wrote: > > Hi, > > > > could I please get reviewes for this tiny fix? > > Grep does not grok the syntax of the replacement of space to newline. > > It causes configure failures on SLES 11. > > > > http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/01/ > Aha, that was the reason for those odd NEEDLE and STACK constructs. :-) > > Goetz, please try this patch instead, which uses the new > BASIC_GET_NON_MATCHING_VALUES function. Hopefully, it works > correctly on > SLES 11 as well. > > diff --git a/make/autoconf/hotspot.m4 b/make/autoconf/hotspot.m4 > --- a/make/autoconf/hotspot.m4 > +++ b/make/autoconf/hotspot.m4 > @@ -443,7 +443,7 @@ > AC_MSG_RESULT(["$JVM_FEATURES_FOR_VARIANT"]) > > # Validate features (for configure script errors, not user errors) > - INVALID_FEATURES=`$GREP -Fvx "${VALID_JVM_FEATURES// /$'\n'}" <<< > "${JVM_FEATURES_FOR_VARIANT// /$'\n'}"` > + BASIC_GET_NON_MATCHING_VALUES(INVALID_FEATURES, > $JVM_FEATURES_FOR_VARIANT, $VALID_JVM_FEATURES) > if test "x$INVALID_FEATURES" != x; then > AC_MSG_ERROR([Internal configure script error. Invalid JVM > feature(s): $INVALID_FEATURES]) > fi > > /Magnus
