Hi Aleksey, the fix looks good.
Best Regards, Thomas On Wed, Apr 25, 2018 at 11:29 AM, Aleksey Shipilev <sh...@redhat.com> wrote: > On 04/25/2018 11:14 AM, Magnus Ihse Bursie wrote: >>> diff -r 5d2da44780ac make/Images.gmk >>> --- a/make/Images.gmk Wed Apr 25 10:38:07 2018 +0200 >>> +++ b/make/Images.gmk Wed Apr 25 10:55:04 2018 +0200 >>> @@ -117,7 +117,7 @@ >>> >>> JLINK_TOOL := $(JLINK) -J-Djlink.debug=true \ >>> --module-path $(IMAGES_OUTPUTDIR)/jmods \ >>> - --endian $(OPENJDK_BUILD_CPU_ENDIAN) \ >>> + --endian $(OPENJDK_TARGET_CPU_ENDIAN) \ >>> --release-info $(BASE_RELEASE_FILE) \ >>> --order-resources=$(call CommaList, $(JLINK_ORDER_RESOURCES)) \ >>> --dedup-legal-notices=error-if-not-same-content \ >>> >>> Testing: x86_64 build, s390x cross-compiled build >> Looks good to me. > > Thanks! > > I guess one reviewer is enough for this kind of change? > No more testing needed? > > -Aleksey >
