On Wed, 2018-04-25 at 08:48 -0700, Erik Joelsson wrote: > The change looks good. You will need to also get approval for pushing to > 10u.
Right. Thanks for the review, Erik! Cheers, Severin > /Erik > > > On 2018-04-25 08:44, Severin Gehwolf wrote: > > Hi, > > > > Can I please get a review for this JDK 10 only fix, which prevents some > > extra link flags getting injected to the build of libjsig.so. JDK 11 is > > not affected. It appears to be a typo. It should be a rather low risk > > change and helps us reduce downstream carried patches. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8202262 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202262/webrev.01/ > > > > Thanks, > > Severin > > > >