Hi, On Tue, 2018-05-08 at 15:20 +0100, Rob McKenna wrote: > No, you're correct. The closed changes do need to be handled by someone > in Oracle so it makes sense to get an Oracle committer to push. > > So: > > A. Yes. > B. You're absolutely right. I'll take care of the push once you've got > the change codereviewed / approved for push.
Thank you, Rob! This seems a rather strange case as the actual change is already pushed[1]. What's missing are the generated-configure.sh changes after "bash make/autoconf/autogen.sh". Not sure what needs to get code- reviewed in this case. Getting the latest revision (ddb10178cbb2) from jdk-updates/jdk10u and then performing the autogen.sh step should give you the changes that need to get pushed. That's what the following webrev is: Bug: https://bugs.openjdk.java.net/browse/JDK-8202784 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202784/webrev.01/ Anyway, can somebody on the build-team rubber-stamp this, please? Thanks, Severin [1] http://hg.openjdk.java.net/jdk-updates/jdk10u/rev/2f8a4aafe85f > Thanks, > > -Rob > > On 08/05/18 15:22, Severin Gehwolf wrote: > > Hi Rob, > > > > I can file a bug and follow the approval process and get it pushed. > > First, I'd like to know whether: > > > > A. An action needs to be taken at all? I assume yes, but just making > > sure. > > B. Contributors outside Oracle can push generated-configure.sh changes? > > I seem to remember that for JDK 8 that has to be done by an Oracle > > sponsor since some generated-configure.sh changes need to be done on > > closed sources. Not sure whether this info is accurate. > > > > Thanks, > > Severin > > > > On Tue, 2018-05-08 at 14:09 +0100, Rob McKenna wrote: > > > Ahem: http://openjdk.java.net/census#jdk-updates > > > > > > -Rob > > > > > > On 08/05/18 14:08, Rob McKenna wrote: > > > > (also, according to http://db.openjdk.java.net/people/ you have > > > > committer rights to the jdk-updates project.) > > > > > > > > -Rob > > > > > > > > On 08/05/18 14:07, Rob McKenna wrote: > > > > > Hi Severin, > > > > > > > > > > You'll need to file a bug and follow the approval request process. > > > > > > > > > > http://openjdk.java.net/projects/jdk-updates/approval.html > > > > > > > > > > -Rob > > > > > > > > > > On 08/05/18 14:56, Severin Gehwolf wrote: > > > > > > Hi, > > > > > > > > > > > > It just occurred to me that JDK 10u seems to still be using > > > > > > generated- > > > > > > configure.sh. If so there is a good chance that my recent push to > > > > > > jdk10u[1] might have broken something. Is it enough to ammend this > > > > > > with > > > > > > this? > > > > > > > > > > > > diff --git a/make/autoconf/generated-configure.sh > > > > > > b/make/autoconf/generated-configure.sh > > > > > > --- a/make/autoconf/generated-configure.sh > > > > > > +++ b/make/autoconf/generated-configure.sh > > > > > > @@ -5187,7 +5187,7 @@ > > > > > > #CUSTOM_AUTOCONF_INCLUDE > > > > > > > > > > > > # Do not change or remove the following line, it is needed for > > > > > > consistency checks: > > > > > > -DATE_WHEN_GENERATED=1516225089 > > > > > > +DATE_WHEN_GENERATED=1525783673 > > > > > > > > > > > > > > > > > > ############################################################################### > > > > > > # > > > > > > @@ -67486,7 +67486,7 @@ > > > > > > BOOTCYCLE_JVM_ARGS_BIG=-Xms64M > > > > > > > > > > > > # Maximum amount of heap memory and stack size. > > > > > > - JVM_HEAP_LIMIT_32="1024" > > > > > > + JVM_HEAP_LIMIT_32="768" > > > > > > # Running a 64 bit JVM allows for and requires a bigger heap > > > > > > JVM_HEAP_LIMIT_64="1600" > > > > > > STACK_SIZE_32=768 > > > > > > > > > > > > Does somebody at Oracle need to push this for me? My sincere > > > > > > appologies for the trouble! > > > > > > > > > > > > Please advise whether anything needs to be done. > > > > > > > > > > > > Thanks, > > > > > > Severin > > > > > > > > > > > > [1] http://hg.openjdk.java.net/jdk-updates/jdk10u/rev/2f8a4aafe85f
