Hi Aleksey,

Thanks for fixing.

I wonder if /c2/ could be added to the exclude pattern instead though, instead 
of enumerating all GCs.

Thanks,
/Erik

> On 19 May 2018, at 11:20, Aleksey Shipilev <sh...@redhat.com> wrote:
> 
> Bug:
>  https://bugs.openjdk.java.net/browse/JDK-8203454
> 
> Other GCs that would eventually bring their own BarrierSetC2 files (e.g. 
> Epsilon, Shenandoah, ZGC)
> would require excluding their "gc/<name>/c2" as well.
> 
> Fix:
> 
> diff -r 5ec7380f671d make/hotspot/lib/JvmFeatures.gmk
> --- a/make/hotspot/lib/JvmFeatures.gmk    Fri May 18 18:31:28 2018 -0700
> +++ b/make/hotspot/lib/JvmFeatures.gmk    Sat May 19 11:01:16 2018 +0200
> @@ -41,7 +41,7 @@
> else
>   JVM_EXCLUDES += opto libadt
>   JVM_EXCLUDE_FILES += bcEscapeAnalyzer.cpp ciTypeFlow.cpp
> -  JVM_EXCLUDE_PATTERNS += c2_ runtime_
> +  JVM_EXCLUDE_PATTERNS += c2_ runtime_ gc/shared/c2 gc/g1/c2
> endif
> 
> ifeq ($(call check-jvm-feature, zero), true)
> 
> Testing: {x86-minimal, x86_64-zero, x86_64-server} builds
> 
> Thanks,
> -Aleksey
> 

Reply via email to