On 6/8/18 5:50 PM, Erik Joelsson wrote:
On 2018-06-07 17:30, David Holmes wrote:
On 8/06/2018 6:11 AM, Erik Joelsson wrote:
I just don't think the extra work is warranted or should be
prioritized at this point. I also cannot think of a combination of
options required for what you are suggesting that wouldn't be
confusing to the user. If someone truly feels like these flags are
forced on them and can't live with them, we or preferably that
person can fix it then. I don't think that's dictatorship. OpenJDK
is still open source and anyone can contribute.
I don't see why --enable-hardened-jdk and --enable-hardened-hotspot
to add to the right flags would be either complicated or confusing.
For me the confusion surrounds the difference between
--enable-hardened-hotspot and --with-jvm-variants=server, hardened and
making the user understand it. But sure, it is doable. Here is a new
webrev with those two options as I interpret them. Here is the help text:
--enable-hardened-jdk enable hardenening compiler flags for all jdk
Typo: 'hardenening' -> 'hardening'
libraries (except the JVM), typically disabling
speculative cti. [disabled]
--enable-hardened-hotspot
enable hardenening compiler flags for
hotspot (all
Typo: 'hardenening' -> 'hardening'
jvm variants), typically disabling speculative cti.
To make hardening of hotspot a runtime choice,
consider the "hardened" jvm variant instead
of this
option. [disabled]
Note that this changes the default for jdk libraries to not enable
hardening unless the user requests it.
Webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.04/
/Erik
Dan
