On 2018-06-15 18:02, Fridrich Strba wrote:
Hello, Magnus,
Your original patch had a problem, since the second statement overwrote
the $1_SRC_HEADER_FLAGS instead of appending to it. With that, things
like osSupport.hpp, jawt_md.h and so on could not be found in build of
tests. So, I modified your patch to read as attached and the build
finished. It is basically a 2-liner.
Sorry, it was untested and made in a bit of a hurry. A better solution
would be to change it to read:
+ # Always add the java header dir
+ $1_SRC_HEADER_FLAGS += $$(addprefix -I, $$(call GetJavaHeaderDir,
$$(MODULE)))
(the += will append to the existing variable, instead of replacing it).
/Magnus
Cheers
Fridrich
On 15/06/18 13:10, Magnus Ihse Bursie wrote:
Here's a better patch. Please try and see if it solves your problems.
Unfortunately, I'm leaving on vacation for today and will be gone most
of the summer, so I can't help sponsor this patch. But if it works, I'm
sure someone else can take over it.
If it does not work, the original patch should at the very least be
changed so that EXTRA_HEADER_DIRS gets an additional "$(call
GetJavaHeaderDir, $(MODULE))", instead of the -I (which I've been trying
hard to eradicate from the CFLAGS).
