Hi Erik, actually, I have a redundant quotation mark at the begging, removed. thanks for spotting this.
Thanks, -- Igor > On Jun 28, 2018, at 9:50 PM, Erik Helin <erik.he...@oracle.com> wrote: > > On 06/29/2018 06:42 AM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html >>> 1 line changed: 0 ins; 0 del; 1 mod; >> Hi all, >> could you please review this one liner fix? >> webrev: http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html > > Hmmm, it seems like you are missing an end-of-string quotation mark in > > + $(info "Skip building of Graal unit tests because 3rd party libraries > directory is not specified) > > Or did I misunderstand the patch? > Thanks, > Erik > >> JBS: https://bugs.openjdk.java.net/browse/JDK-8206088 >> testing: make build-test-hotspot-jtreg-graal w/ empty GRAALUNIT_LIB >> Thanks, >> -- Igor
