+1

Thanks,
David

On 6/07/2018 7:49 AM, Christian Tornqvist wrote:
I agree with Igor, this wouldn’t have been found by “normal” pre-integration 
testing. Change looks good, sorry for the extra work you had to do.

Thanks,
Christian

On Jul 5, 2018, at 5:33 PM, Igor Ignatyev <[email protected]> wrote:

well, I did test it last time, I just didn't expect that some parts of infra do 
submission a bit weirdly. now (at least as far as I can tell) I tested 
submission in the exact same way.

-- Igor

On Jul 5, 2018, at 2:18 PM, Vladimir Kozlov <[email protected]> wrote:

I am fine with re-do if you were able re-test it to verify that it actually 
works. Not like last time.

Thanks,
Vladimir

On 7/5/18 1:02 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8206429/webrev.00/index.html
243 lines changed: 0 ins; 124 del; 119 mod;
Hi all,
could you please review this redo of 8202561? 8202561 was backed out b/c our CI 
infra didn't support multiple test group files. now such configurations are 
supported, so 8202561 can be re-integrated.
the patch is the exact 8202561 changeset and it has applied clearly.
webrev: http://cr.openjdk.java.net/~iignatyev//8206429/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8206429
testing: successfully submitted adhoc jobs which use a "quick" test group in 
the same way CI system does
Thanks,
-- Igor


Reply via email to