On 09/07/18 16:43, Erik Joelsson wrote:
Hello,
I would not like to change the behavior of the existing macro since
that will have complications for many parts of the build. We could
perhaps extend it into a special version for the intellij generator
script. It would be possible to figure out which modules have gensrc
dirs by looking for gensrc/Gensrc-<module>.gmk makefiles, or we could
simply always add a potential gensrc dir to the configuration for
every module. It depends on how well Intellij copes with non existing
source directories?
Non-existing folders are handled fine by IntelliJ - as soon as they will
be available and/or change, IntelliJ will re-index them, which is what
we want.
Maurizio
The reason building all gensrc has so many dependencies is Graal. They
require all their module dependencies to have been built before they
can generate their sources. The rest of gensrc is pretty cheap to build.
/Erik
On 2018-07-09 04:18, Maurizio Cimadamore wrote:
Hi,
I was playing with the script for IntelliJ project generation, and I
noted that make does not report generated source roots (e.g. those
under support/gensrc) _unless_ such folders exist in the file system.
This is a bit of a let down - normally one would create the IJ
project on an empty (but configured) OpenJDK repo - and if you do
that, right now there will be missing source roots.
If you call 'make gensrc', the sources will be picked up by the
script/makefiles, but that is a lengthy target to call, as it seems
to build all the interim tools and java.base.
Would it be possible to correct this behavior, and to have the
results of FindModuleSrcDirs _not_ depend on what has already been
built?
Cheers
Maurizio
