On 2018-07-19 09:54, Christian Thalinger wrote:
On Jul 19, 2018, at 12:44 PM, Erik Joelsson <[email protected]
<mailto:[email protected]>> wrote:
On 2018-07-19 09:16, Christian Thalinger wrote:
Well, the issue is this:
exploded-image: exploded-image-base release-file
release-file: create-source-revision-tracker
store-source-revision:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f
SourceRevision.gmk store-source-revision)
create-source-revision-tracker:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f
SourceRevision.gmk create-source-revision-tracker)
We need these targets because all isn’t really used.
Ah, the all target is tricking me and should be removed if not called
from anywhere. Then your suggested patch is good (except for missing
the :=).
Do you want me to remove the all: target?
Yes, that would be a good cleanup to avoid confusion.
/Erik
/Erik
+store-source-revision: $(STORE_SOURCE_REVISION_TARGET)
+
+create-source-revision-tracker:
$(CREATE_SOURCE_REVISION_TRACKER_TARGET)
+
all: store-source-revision create-source-revision-tracker
FRC: # Force target
Do you really need the separate variables? Since both of them are
built by all anyway, I would just have one variable TARGETS to
which you add everything you wish to build and finish with "all:
$(TARGETS)".
/Erik
