> On Jul 30, 2018, at 8:00 AM, Michal Vala <mv...@redhat.com> wrote: > On 07/27/2018 06:22 PM, Kim Barrett wrote: >> If it’s really necessary to be able to build JDK 12 with earlier versions of >> Visual Studio for now >> (as I said, it might become impossible later for other reasons), the proper >> fix is to replace the >> call to snprintf with os::snprintf, which is what should have been used in >> the first place. I missed >> that when I was reviewing JDK-8207359. > > You're right. That also solves the issue with VS2013 and is imho proper way > to implement it anyway. Here's the new webrev: > http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8208084/webrev.01/ > > -- > Michal Vala > OpenJDK QE > Red Hat Czech
Looks good.
