On Tue, Aug 21, 2018 at 12:14 PM, Magnus Ihse Bursie <[email protected]> wrote: > >> Yes, please. And it would be absolutely fantastic to actually build it and >> ship it in default >> OpenJDK images :) > > > Am I correct in understanding that there are no more legal barriers towards > doing such a thing anymore? > > I can easily add a new make target to build hsdis. > > Adding a new binary to the OpenJDK images will require a CSR.
Do we really need a CSR for hsdis? hsdis is a shared library/DLL and not a "binary" which can be called by the user or executed stand-alone. The functionality offered by hsdis is only accessible by already existing command line parameters (like -XX:+PrintAssembly). The CSR FAQ [1] only mentions (among others): - Adding or removing a command in $JDK/bin - Adding, removing, or changing a command line option which both don't seem to be applicable to hsdis. Regards, Volker PS: and just to be clear - I'm all for having hsdis in the default images :) [1] https://wiki.openjdk.java.net/display/csr/CSR+FAQs > This in turn > will likely require that there are proper tests that can be run (I have no > idea of the current status of hsdis testing). I can't help you with either > of these two. > > /Magnus
