Thanks Goetz,
I've created an hg export below..
I've not used jdk-submit, i've tested it locally on xLinux and zLinux.
Cheers
Andrew
# HG changeset patch
# User aleonard
# Date 1535641094 -3600
# Thu Aug 30 15:58:14 2018 +0100
# Node ID 592a8ad8d4c16287c316d018a0a402148720718b
# Parent 1ddd1ec044311512c55643bed641859e78b9d25e
8209786: disable gcc warnings for libmlib & libfdlibm to enable gcc 7.3 on
zLinux
diff -r 1ddd1ec04431 -r 592a8ad8d4c1 make/lib/Awt2dLibraries.gmk
--- a/make/lib/Awt2dLibraries.gmk Thu Aug 30 09:08:23 2018 -0400
+++ b/make/lib/Awt2dLibraries.gmk Thu Aug 30 15:58:14 2018 +0100
@@ -55,6 +55,7 @@
OPTIMIZATION := HIGHEST, \
CFLAGS := $(CFLAGS_JDKLIB) \
$(BUILD_LIBMLIB_CFLAGS), \
+ DISABLED_WARNINGS_gcc := shift-negative-value, \
LDFLAGS := $(LDFLAGS_JDKLIB) \
$(call SET_SHARED_LIBRARY_ORIGIN), \
LIBS := $(JDKLIB_LIBS), \
diff -r 1ddd1ec04431 -r 592a8ad8d4c1 make/lib/CoreLibraries.gmk
--- a/make/lib/CoreLibraries.gmk Thu Aug 30 09:08:23 2018 -0400
+++ b/make/lib/CoreLibraries.gmk Thu Aug 30 15:58:14 2018 +0100
@@ -68,7 +68,7 @@
CFLAGS_linux_ppc64le := -ffp-contract=off, \
CFLAGS_linux_s390x := -ffp-contract=off, \
CFLAGS_linux_aarch64 := -ffp-contract=off, \
- DISABLED_WARNINGS_gcc := sign-compare misleading-indentation, \
+ DISABLED_WARNINGS_gcc := sign-compare misleading-indentation
array-bounds, \
DISABLED_WARNINGS_microsoft := 4146 4244 4018, \
ARFLAGS := $(ARFLAGS), \
OBJECT_DIR := $(SUPPORT_OUTPUTDIR)/native/$(MODULE)/libfdlibm, \
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: [email protected]
From: "Lindenmaier, Goetz" <[email protected]>
To: Andrew Leonard <[email protected]>, Brian Burkhalter
<[email protected]>
Cc: "[email protected]" <[email protected]>,
"build-dev ([email protected])" <[email protected]>
Date: 30/08/2018 15:36
Subject: RE: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux
Hi Leonard,
the change looks good to me.
I'll test it tonight, to make sure it runs with our compilers.
Did you run it through jdk-submit?
If you supply a patch with all the changeset information (like
from hg export) that jchecks fine, I'll sponsor this for you.
Best regards,
Goetz.
> -----Original Message-----
> From: core-libs-dev <[email protected]> On Behalf
> Of Andrew Leonard
> Sent: Donnerstag, 30. August 2018 14:19
> To: Brian Burkhalter <[email protected]>
> Cc: [email protected]
> Subject: Re: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux
>
> Hi Brian,
> Thanks for taking a look at this, I have just done a rebuild with a new
> patch with appropriate gcc disable warnings for these libraries:
>
http://cr.openjdk.java.net/~aleonard/8209786/webrev.01/
> This works fine, so if you think this is a more favourable approach for
> these libraries? i'd like to get this merged please.
> Thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> Phone internal: 245913, external: 01962 815913
> internet email: [email protected]
>
>
>
>
> From: Brian Burkhalter <[email protected]>
> To: Andrew Leonard <[email protected]>
> Cc: [email protected]
> Date: 28/08/2018 15:52
> Subject: Re: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux
>
>
>
> Hi Andrew,
>
> It was suggested that it would be preferable to dial down the
compilation
> settings for the fdlibm code rather than make a source code change. Was
> this investigated?
>
> Thanks,
>
> Brian
>
> On Aug 28, 2018, at 7:18 AM, Andrew Leonard
> <[email protected]>
> wrote:
>
> We have discovered issues with gcc 7.3 on zLinux, combined with
OpenJDK's
> default compiler options has highlighted a couple of native code issues,
> with undefined behaviours:
> - validating loop test array bounds
> - left shifts of negative values
> I have created bug
https://bugs.openjdk.java.net/browse/JDK-8209786
> and attached the webrev fix here:
>
http://cr.openjdk.java.net/~aleonard/8209786/webrev.00/
>
> This has already been discussed and refined on the "s390x-port-dev"
> maillist
> and as it was pointed out, it should have been posted here...
>
> I'd like to request a sponsor for this fix please?
>
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
