On 2018-09-05 09:49, Zambonifofex wrote:
Hello. It seems to work fine on Bash. On Fish, I get the following error:fish: Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'. cd /home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs && \ ^ Fish uses the ‘and’ command <https://fishshell.com/docs/current/commands.html#and> instead of Bash’s ‘&&’ operator.
Okay... So what happens if you run the command in bash, which is what make will be using?
We do set SHELL to bash for make, so it *should* be running command lines using bash.
But just to be sure, please test running the make command from bash as well. /Magnus
On Wed, Sep 5, 2018 at 4:35 AM Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote:On 2018-08-22 17:45, Ioi Lam wrote: Looks like it's this command that failed: cd /home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs && \ /usr/bin/nm --defined-only *.o | /usr/bin/nawk '{ if ($3 ~ /^_ZTV|^gHotSpotVM|^UseSharedSpaces$|^_ZN9Arguments17SharedArchivePathE$/) print $3; }' | /usr/bin/sort -u Try cut-and-paste that into a terminal and see what error it reports, Zambonifofex, This is very good advice. You should try it. If it does not return a long list of symbols, try breaking it down in parts to see if you can figure out where it fails. /Magnus Thanks - Ioi On 8/21/18 11:18 PM, David Holmes wrote: Interesting - there is no actual error report in the log. Only this: lib/JvmMapfile.gmk:141: recipe for target '/home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/symbols-objects' failed Looking at the gmk file we have: $(JVM_OUTPUTDIR)/symbols-objects: $(BUILD_LIBJVM_ALL_OBJS) $(call LogInfo, Generating symbol list from object files) $(CD) $(JVM_OUTPUTDIR)/objs && \ $(DUMP_SYMBOLS_CMD) | $(NAWK) $(FILTER_SYMBOLS_AWK_SCRIPT) | $(SORT) -u > $@ I'd have to suspect one of the command variables is not set. I suspect the actual error text may be redirected to the symbols-objects file, but unfortunately that has been deleted by 'make'. Check the generated spec.gmk file for the value of DUMP_SYMBOLS_CMD and NAWK. David On 22/08/2018 1:45 PM, Zambonifofex wrote: Hello. I’ve run the following commands (using the Fish shell): /home/zambonifofex/jdk/ $ make hotspot > ~/log.txt ^&1 /home/zambonifofex/jdk/ $ env LOG=trace make hotspot > ~/log-trace.txt ^&1 /home/zambonifofex/jdk/ $ I’ll attach the generated files in this email. Thanks once again. On Tue, Aug 21, 2018 at 8:51 PM Gustavo Romero <grom...@linux.vnet.ibm.com> wrote: Hi, On 08/21/2018 08:00 PM, David Holmes wrote: Hi, You need to search further up the build log to try and find the actual error that occurred when building hotspot. Run "make hotspot" and it should be easier to see. In addition to David's suggestion you can also add before the command LOG=trace, like: $ LOG=trace make hotspot to spot the executed commands in the build process. Regards, Gustavo David On 20/08/2018 11:53 AM, Zambonifofex wrote: Hello, everyone. I am new to collaborating to the JDK, so sorry if this question is too newbie‐ish. I have recently been affected by a minor bug in the ‘java.desktop’ module on Linux. I figured I’d try to fix it by myself, so I followed the steps in the “How to Contribute” page, the “Building” page, as well as some more that I could find online. The bug number is ‘7162479’. The bug is that it calling ‘setLocationByPlatform(true)’ on a ‘JFrame’ will not work if ‘setResizable(false)’ has been called on the same ‘JFrame’. When I tried to build the JDK with ‘make images’, after getting a couple errors related to the changes I made and fixing them, I started to face a strange error that was not related to the changes I made at all. Here is the log I get when trying to run ‘make images’ currently, as well as the output of ‘hg id’, if that’s of any help (where ‘/home/zambonifofex/jdk $’ is the prompt): /home/zambonifofex/jdk/ $ hg id 2e91d927e00c+ tip /home/zambonifofex/jdk/ $ make images Building target 'images' in configuration 'linux-x86_64-normal-server-release' lib/JvmMapfile.gmk:141: recipe for target '/home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/symbols-objects' failed make[3]: *** [/home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/symbols-objects] Error 1 make[3]: *** Deleting file '/home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/symbols-objects' make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed make[2]: *** [hotspot-server-libs] Error 1 make[2]: *** Waiting for unfinished jobs.... ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-release' (exit code 2) === Make failed targets repeated here === lib/JvmMapfile.gmk:141: recipe for target '/home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/symbols-objects' failed make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed === End of repeated output === Hint: Try searching the build log for the name of the first failed target. Hint: See doc/building.html#troubleshooting for assistance. /home/zambonifofex/jdk/make/Init.gmk:300: recipe for target 'main' failed make[1]: *** [main] Error 1 /home/zambonifofex/jdk/make/Init.gmk:186: recipe for target 'images' failed make: *** [images] Error 2 /home/zambonifofex/jdk/ $ Any help would be appreciated. Thanks in advance.
