Hello,

Looks good. Perhaps add a comment explaining why the otherwise unusual choice of collection class is used.

/Erik

On 2018-09-13 15:20, Magnus Ihse Bursie wrote:
The file make/langtools/tools/propertiesparser/PropertiesParser.java b/make/langtools/tools/propertiesparser/PropertiesParser.java is used to convert .properties files into .java files as part of the gensrc step.

However, due to it's use of creating it's output directly from HashMaps, it's not guaranteed to be stable, and is causing spurios differences in our cmp-baseline builds.

Bug: https://bugs.openjdk.java.net/browse/JDK-8210731
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8210731-properties-parser-is-not-stable/webrev.01

/Magnus


Reply via email to