Looks good.
/Erik
On 2018-09-17 15:15, Jiangli Zhou wrote:
Please review the change for JEP 341 (Default CDS Archives) sub-task,
JDK-8210592.
Currently, there are sub-sets of tiered tests running in CDS mode
(defined in closed tier5 and tier6 test definitions). These tests are
also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE
is used to create a CDS archive using the default classlist before
executing those tests in CDS-mode.
When the default CDS archive is enabled, it is no longer necessary to
execute those tests in CDS mode explicitly since all tiered testing
enables the default CDS archive by default. The change in the webrev
removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test sets
in CDS mode are converted to run in non-CDS mode (with -Xshare:off
enabled explicitly) in tier5 and tier6. The conversion is done in the
closed repo.
webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/
JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592
Tested tier5 and tier6 with the default CDS archive patch enabled.
Thanks,
Jiangli
