Hi Volker, Aleksey, Voker, your change looks good.
I also think CDS should be turned off on minimal VM, and also the case for zero a few lines below should be removed in a similar manner. But I'll leave to you whether you want to handle that in a separate fix. Best regards, Goetz. > -----Original Message----- > From: hotspot-runtime-dev <hotspot-runtime-dev- > boun...@openjdk.java.net> On Behalf Of Volker Simonis > Sent: Montag, 8. Oktober 2018 10:19 > To: build-dev <build-dev@openjdk.java.net>; hotspot-runtime- > d...@openjdk.java.net runtime <hotspot-runtime-...@openjdk.java.net> > Subject: RFR(XS): 8211837: Creation of the default CDS Archive should > depend on ENABLE_CDS > > Hi, > > can I please have a review for the following trivial build fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8211837/ > https://bugs.openjdk.java.net/browse/JDK-8211837 > > It makes no sense to try to create a default CDS archive on VMs which > don't support CDS at all. We already have '--enable_cds' which > defaults to 'true' on all platforms except AIX. > > The check for '--enable_cds_archive' should use the result of > '--enable_cds' (which is saved in "ENABLE_CDS") and only enable > default archive creation if CDS is enabled. > > Failure to do so currently breaks the AIX build (after JDK-)8202951 was > pushed). > > Thank you and best regards, > Volker
