On 21/11/2018 02:46, Nick Gasson wrote:
Hi,
Can someone please help me review this small makefile patch to
fix an issue with java.io.File::setLastModified on 32-bit
systems?
https://bugs.openjdk.java.net/browse/JDK-8214077
http://cr.openjdk.java.net/~njian/8214077/webrev.0/
If the file size is > 2GB so that the size won't fit in a signed
32-bit off_t all stat() calls will fail with EOVERFLOW. This causes
the native method UnixFileSystem::setLastModifiedTime to fail as it
uses stat() to preserve the access time. It also causes other methods
like File::length and File::lastModified to return 0.
Have you looked at replacing the remaining usages of stat changed to
stat64 instead?
-Alan
