Not a reviewer, but also looks good to me. I encountered this issue myself while working on the WSL patch (perhaps that's also how you found this issue). I do wonder if this is the only utility that has this issue - if not, another possibility could be where we prefix PANDOC with FIXPATH, we could check if PANDOC is empty before prefixing FIXPATH (if it's empty we can just not prefix FIXPATH).
Thanks, -Andrew -----Original Message----- From: build-dev <build-dev-boun...@openjdk.java.net> On Behalf Of Magnus Ihse Bursie Sent: Thursday, December 20, 2018 2:49 AM To: Erik Joelsson <erik.joels...@oracle.com> Cc: build-dev <build-dev@openjdk.java.net> Subject: Re: RFR: JDK-8215635: Pandoc check in Docs.gmk does not work on Windows Lgtm. /Magnus > 19 dec. 2018 kl. 12:40 skrev Erik Joelsson <erik.joels...@oracle.com>: > > Hello, > > In JDK-8214910 a check for if the PANDOC variable had a value was added to > Docs.gmk. This check does not work correctly on Windows where PANDOC will > always have the fixpath prefix. This patch adds a separate ENABLE_PANDOC > variable that make can check. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215635 > > Webrev: http://cr.openjdk.java.net/~erikj/8215635/webrev.01/ > > /Erik >
