Thanks!
/Claes
On 2019-01-07 16:52, Erik Joelsson wrote:
Looks good.
/Erik
On 2019-01-07 16:02, Claes Redestad wrote:
Hi,
current use of -Xlint makes the build-microbenchmark fail if one
attempts to add a microbenchmark that uses non-JMH annotations.
Patch selectively disable the processing lint option without disabling
other linters.
Bug: https://bugs.openjdk.java.net/browse/JDK-8216275
Patch:
diff -r b587ca419e2c make/test/BuildMicrobenchmark.gmk
--- a/make/test/BuildMicrobenchmark.gmk Mon Jan 07 13:10:20 2019 +0100
+++ b/make/test/BuildMicrobenchmark.gmk Mon Jan 07 15:46:36 2019 +0100
@@ -78,7 +78,7 @@
# Build microbenchmark suite for the current JDK
$(eval $(call SetupJavaCompilation, BUILD_JDK_MICROBENCHMARK, \
SETUP := MICROBENCHMARK_JAVA_COMPILER, \
- ADD_JAVAC_FLAGS := -cp $(MICROBENCHMARK_CLASSPATH) -Xlint -Werror, \
+ ADD_JAVAC_FLAGS := -cp $(MICROBENCHMARK_CLASSPATH) -Xlint
-Xlint:-processing -Werror, \
SRC := $(MICROBENCHMARK_SRC), \
BIN := $(MICROBENCHMARK_CLASSES), \
))
/Claes
