On 2019-01-30 17:37, Andrew Leonard wrote:
Thanks David,
I just found the reference you mention, it is a little vague, but says
maybe as you said. I've reworked and tested the following which seems
better:
   NUM_CORES=`lparstat -m | grep -o "lcpu=[[0-9]]*" | cut -d "=" -f 2`
I'll create a new webrev with this.
Note that you should use $GREP and $CUT; in theory we should also check for lparstat, but we've been sloppy with that for the other cpu checking methods so maybe we can be that for AIX here as well.

/Magnus
Thanks
Andrew

Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com




From:   David Holmes <david.hol...@oracle.com>
To:     Erik Joelsson <erik.joels...@oracle.com>, Andrew Leonard
<andrew_m_leon...@uk.ibm.com>, build-dev@openjdk.java.net
Date:   30/01/2019 02:25
Subject:        Re: Proposal: JDK-8217896: Make better use of LCPUs when
building on AIX



On 30/01/2019 3:05 am, Erik Joelsson wrote:
Hello,

I'm OK with this, but since I can't verify it at all, I would be more
comfortable if one of the other AIX users would review this as well.
Ditto. I did some googling on this and pmcycles is flagged as maybe
being deprecated in the future and may require privileges to execute.
lparstat -i seems to be more commonly used.

David
-----

/Erik

On 2019-01-29 05:08, Andrew Leonard wrote:
Hi,
Please can I get a sponsor for this build performance enhancement on
AIX,
by better determining the number of LCPUs on smt AIX machines:
https://urldefense.proofpoint.com/v2/url?u=https-3A__cr.openjdk.java.net_-7Ealeonard_8217896_webrev.00_&d=DwIDaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=NaV8Iy8Ld-vjpXZFDdTbgGlRTghGHnwM75wUPd5_NUQ&m=FpNeQfFJBut0AAVlbC0w7o0urDCArfDb4PY1TtMVW4I&s=8vmPiiNU5P6MnXKdE-eyyBm48kgCssjH5VyWHAt5zcM&e=

My testing shows up to 30% improved build times when leveraging the
available LCPUs.
Many thanks
Andrew

Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leon...@uk.ibm.com


Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with
number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU




Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Reply via email to