Thanks . A second review would be great . Best regards, Matthias
> -----Original Message----- > From: Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> > Sent: Mittwoch, 6. Februar 2019 17:38 > To: Baesken, Matthias <matthias.baes...@sap.com>; 'hotspot- > d...@openjdk.java.net' <hotspot-...@openjdk.java.net>; 'build- > d...@openjdk.java.net' <build-dev@openjdk.java.net> > Subject: Re: RFR [XS] : 8218562: handle HOTSPOT_BUILD_COMPILER for > clang/xlclang and cleanup HOTSPOT_BUILD_COMPILER settings > > On 2019-02-06 16:17, Baesken, Matthias wrote: > > Hello, please review this small change . > > > > I noticed (when looking into AIX xlc16 / xlclang++) the following: in > > the > case that clang is used for compilation, HOTSPOT_BUILD_COMPILER claims > to be a gcc . > > This is a bit misleading. > > This change adjusts the setting for clang usage on AIX (for future usage > with xlclang++) and macOSX. > > > > Additionally I removed some old HOTSPOT_BUILD_COMPILER for legacy > Oracle / Sun Studio versions ). > > > > > > Bug/webrev : > > > > https://bugs.openjdk.java.net/browse/JDK-8218562 > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218562.0/ > Looks good to me. > > /Magnus > > > > > > Thanks, Matthias
