+1
Cheers, Mikael > On Feb 15, 2019, at 2:28 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > That would look better. Here is a new webrev: > http://cr.openjdk.java.net/~erikj/8217032/webrev.03/index.html > > /Erik > > On 2019-02-15 14:04, Mikael Vidstedt wrote: >> How about having the variable be called something like PANDOC_MARKDOWN_FLAG, >> and have the value include “markdown”? >> >> Cheers, >> Mikael >> >>> On Feb 15, 2019, at 11:57 AM, Erik Joelsson <erik.joels...@oracle.com> >>> wrote: >>> >>> Thanks for the input. Here is a new webrev that only tries to disable the >>> "smart" extension if it is present. >>> >>> http://cr.openjdk.java.net/~erikj/8217032/webrev.02/index.html >>> >>> /Erik >>> >>> On 2019-02-14 23:34, Magnus Ihse Bursie wrote: >>>> On 2019-02-15 00:26, Erik Joelsson wrote: >>>>> Please review this minor fix. The JDK build now has support for >>>>> generating man pages, and will try to do so if it finds pandoc on the >>>>> system. Unfortunately, not all versions of pandoc are valid, and if a bad >>>>> version is found, the build will fail. This patch adds an extensions >>>>> check for the found pandoc in configure, and if the "smart" extension >>>>> that we use is missing, pandoc is disabled. >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217032 >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~erikj/8217032/webrev.01/ >>>> Actually, the problem is slightly more subtle. :( >>>> >>>> We're not using the "smart" extension, we're disabling it. >>>> >>>> If the pandoc we discover does not have the smart extension, we should >>>> instead use to output format "markdown" instead of "markdown-smart". This >>>> is what we used before, and it worked all well, until I updated the >>>> version of markdown used by jib, and it started doing "smart" (actually: >>>> dumb) quoting, and I had to disable it. >>>> >>>> Since the version of pandoc commonly installed by Ubuntu (and maybe other >>>> distros as well) is old enough to not contain the smart extension, I don't >>>> think it's good to disable it -- after all, it works just perfectly; but >>>> we should adjust the "flags" to markdown in that case. >>>> >>>> /Magnus >>>> >>>>> /Erik >>>>>
