Looks ok.

/Erik

On 2019-05-16 04:34, Baesken, Matthias wrote:
Hello,   the updated webrev  is here :


http://cr.openjdk.java.net/~mbaesken/webrevs/8223944.1/


Best regards, Matthias




On 2019-05-15 01:16, Baesken, Matthias wrote:
Hi Alan,   thanks for pointing me  at the old discussion .

http://mail.openjdk.java.net/pipermail/build-dev/2016-
February/016602.html
talks about performance benefits .  Are you aware of some  benchmarks
that showed the improvements ?
In reality,  if you have the latest  distro versions you might be lucky and you
have a nice recent zlib 1.2.11  .
However on older distros , you run in reality  into older zlibs  (often I see
1.2.8).  I don't think that this is a very good status .

At least I think  building.md  should be fixed to  state the real status , the
current  info is wrong :

"Certain third-party libraries used by the JDK (libjpeg, giflib, libpng, lcms
and zlib) are included in the JDK repository. The default behavior of the
JDK build is to use this version of these libraries, but they might be
replaced by an external version. To do so, specify `system` as the
`<source>`
option in these arguments. (The default is `bundled`)."



Btw  how is building.html  generated ,  is this coming from  building.md  ?
Yes, you need to configure with pandoc. Then you run "make
update-build-docs".

/Erik

Reply via email to