On Wed, 2019-06-26 at 13:04 +0100, Andrew John Hughes wrote: > > On 25/06/2019 10:04, Severin Gehwolf wrote: > > Hi, > > > > Could somebody please review this 8u backport? The build system in 8 is > > different, especially hotspot makefiles. Note, libjsig.so is part of > > the hotspot build. The patch is different in 8 (over 11) due to this > > reason. This is a Linux-only change and should be low risk. Thoughts? > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210761 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/01/webrev/ > > > > Change in JDK 11: > > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/e7aa96dc0b1e > > > > Testing: Manual build of slowdebug/fastdebug/release on x86_64. > > Fastdebug/release builds receive the -O3 flag, slowdebug not. As > > expected. > > > > Thanks, > > Severin > > > > The 11u fix applies to all 'unix' platforms, as far as I can see. Should > the 8u equivalent not also be applied to the solaris, bsd and aix > subdirectories as well for consistency?
Here you go: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/02/webrev/ I cannot really test on bsd, solaris or aix, though :( Appreciate any testers for those platforms. Thanks, Severin
