Looks good to me, thanks!
Jan
On 10. 09. 19 17:47, Joe Darcy wrote:
Hi Jan,
On 9/10/2019 5:36 AM, Jan Lahoda wrote:
Hi Joe,
On 09. 09. 19 21:58, Joe Darcy wrote:
Hello,
Looking ahead to JDK 13 GA scheduled for next week, please review
8225761: Update --release 13 symbol information after JDK 13 GA
http://cr.openjdk.java.net/~darcy/8225761.0/
for JDK 14. This information was generated using JDK 13 b33. If there
happens to be another JDK 13 build between now and GA, not expected,
I'll regenerate the data.
(I don't know why the list of modules in make/data/symbols/symbols
differs between now and the previous time generation script was run.)
I see two new modules were added: java.security.jgss and jdk.jartool.
It seems there actually was an API added in java.security.jgss - field
KRB_NT_ENTERPRISE in javax/security/auth/kerberos/KerberosPrincipal:
http://hg.openjdk.java.net/jdk/jdk/rev/d65d3c37232c
So I suspect the java.security.jgss-D.sym.txt will need to be included
as well.
For jdk.jartool, I don't think there was an API change, but some
InnerClasses attribute was changed and the tool generated the
description of the new state. So it might be good to include the
jdk.jartool-D.sym.txt file as well.
I overlooked the new files that were created by the script; updated webrev:
http://cr.openjdk.java.net/~darcy/8225761.1/
Files added for java.security.jgss-D.sym.txt and jdk.jartool-D.sym.txt.
Thanks,
-Joe
