Hi Magnus,
Looks good to me. Although I cannot provide any reproducible problematic
instance, there have been instances where native tools, such as `date`
command had produced localized date, and the build failed to parse it in
US format. Anyways, it is a good preventive measure to me.
Naoto
On 10/2/19 2:06 AM, Magnus Ihse Bursie wrote:
From the bug report:
We should prefix LC_ALL=C for most, maybe all, tools we use when building.
This probably means we should run "export LC_ALL=C" early in the
configure script as well.
---
The fix itself is trivial. While I know we've had several issues
regarding localization, I could not find any specific instances now that
I was looking for them. I searched JBS for a while but could not dig up
anything that was reproducible. So, unfortunately, I have been unable to
verify that this solves any actual problems. That being said, I believe
this is a prudent fix that should have been in place long time ago. But
if anyone can give me a concrete example that breaks so that I can
verify that this helps, please let me know.
Bug: https://bugs.openjdk.java.net/browse/JDK-8065704
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8065704-LC_ALL/webrev.01
/Magnus
