Looks good now. /Magnus
> 4 nov. 2019 kl. 21:21 skrev Ivan Gerasimov <[email protected]>: > > Thank you Magnus for your suggestion! > > Please see the webrev updated accordingly: > > http://cr.openjdk.java.net/~igerasim/8233422/01/webrev/ > > With kind regards, > > Ivan > > >> On 11/4/19 2:20 AM, Magnus Ihse Bursie wrote: >> >> >>> On 2019-11-03 15:51, Jonathan Gibbons wrote: >>> Forwarding to build-dev. >>> >>> build-folk, >>> >>> This one's for you. >>> >>> -- Jon >>> >>>> On 11/1/19 4:24 PM, Ivan Gerasimov wrote: >>>> Hello! >>>> >>>> Every javadoc HTML page has a title, which includes the product and the >>>> version information. >>>> >>>> For example, for the page [1] it is "String (Java 13 SE & JDK 13 )" >>>> >>>> [1] >>>> https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/lang/String.html >>>> >>>> Note the extra space before the closing parenthesis. >>>> >>>> Would you please help review a trivial fix, which removes this extra space? >>>> >>>> (The space will still be preserved if the build information needs to be >>>> included.) >>>> >>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8233422 >>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8233422/00/webrev/ >> Good catch! However, there's an idiomatic way to achieve this in our >> makefiles, without introducing a new $(EMPTY_STRING). >> >> Instead of: >> >> DRAFT_MARKER_TITLE := $(EMPTY_STRING) [ad-hoc build] >> >> do this: >> >> DRAFT_MARKER_TITLE := $(SPACE)[ad-hoc build] >> >> /Magnus >> >> >> > -- > With kind regards, > Ivan Gerasimov >
